Mop and bucket interaction fix #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added return values to attackby_secondary to prevent the default action of calling attackby. Added a message for wringing out dry mop.
dwasint
reviewed
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixed the right click interaction between buckets and mops. Before, right clicking on the bucket with a mop was also trigging the effect of a left click. I added return values to attackby_secondary to stop this fallback behavior.
While I was at it I added a check to see if the mop was empty and made it display a message to inform the user.
Why It's Good For The Game
It's a fix to a broken mechanic. It stops the mop from instantly rewetting in the buckets contents when you are attempting to wring it out.
Changelog
🆑
add: Added new message when trying to wring out a dry mop into a bucket.
fix: Fixed right clicking a mop on a bucket also acting as a left click.
/:cl: